codemirror/lang-javascript
1
0
Fork 0
Code Pull requests Activity

fix arrow functions auto-closing JSX tag #10

Closed
szymonkaliski wants to merge 1 commit from patch-1 into main
pull from: patch-1
merge into: codemirror:main
Conversation 2 Commits 1 Files changed 1 +1
szymonkaliski commented 2023-04-04 18:33:33 +02:00 (Migrated from github.com)
Copy link

Currently writing:

<button onClick={()= } />

and typing > to the right of = incorrectly auto-closes the tag to:

<button onClick={()=></button> } />

this PR fixes this behavior.

Currently writing: ```jsx <button onClick={()= } /> ``` and typing `>` to the right of `=` incorrectly auto-closes the tag to: ```jsx <button onClick={()=></button> } /> ``` this PR fixes this behavior.
marijnh commented 2023-04-05 13:56:22 +02:00 (Migrated from github.com)
Copy link

Thanks for looking into that. I've pushed a somewhat more general patch instead that also fixes it.

Thanks for looking into that. I've pushed a somewhat more general patch instead that also fixes it.
👍 1
szymonkaliski commented 2023-04-06 19:02:36 +02:00 (Migrated from github.com)
Copy link

awesome, thanks! any chance this could be published?

awesome, thanks! any chance this could be published?

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-javascript!10
No description provided.