codemirror/lang-javascript
1
0
Fork 0
Code Pull requests Activity

Fix type errors in complete.ts #13

Merged
meyer merged 1 commit from fix-type-errors into main 2023-08-11 17:45:51 +02:00
Conversation 1 Commits 1 Files changed 1 +2 -2
meyer commented 2023-08-11 15:34:48 +02:00 (Migrated from github.com)
Copy link

While digging around this repository I happened upon two minor type errors. cm-buildhelper doesn’t seem to mind them but I figured they’re easy to fix.

While digging around this repository I happened upon two minor type errors. `cm-buildhelper` doesn’t seem to mind them but I figured they’re easy to fix.
marijnh commented 2023-08-11 17:45:35 +02:00 (Migrated from github.com)
Copy link

Weird. TypeScript seems to usually infer this pattern (declare empty array, push typed values into it later) just fine, but indeed, on TypeScript 4.9.5 it just silently types it as any[]. I guess you have a version that complains about that.

Weird. TypeScript seems to usually infer this pattern (declare empty array, push typed values into it later) just fine, but indeed, on TypeScript 4.9.5 it just silently types it as `any[]`. I guess you have a version that complains about that.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-javascript!13
No description provided.