codemirror/lang-markdown
1
0
Fork 0
Code Pull requests Activity

Enable enter key continuation for GFM task list #2

Merged
masad-frost merged 2 commits from fm-enter-task-list into main 2022-04-12 22:43:25 +02:00
Conversation 3 Commits 2 Files changed 1 +5 -3
masad-frost commented 2022-04-10 11:36:44 +02:00 (Migrated from github.com)
Copy link

This adds an optional 3rd capturing group for task lists and passes it to the enter completion context.

Assumed we don't care if GFM is enabled or not.

closes #1

This adds an optional 3rd capturing group for task lists and passes it to the enter completion context. Assumed we don't care if GFM is enabled or not. closes #1
marijnh commented 2022-04-11 09:06:59 +02:00 (Migrated from github.com)
Copy link

Is it intentional that this copies the 'done' status from the previous item, rather than creating new items as [ ]?

Is it intentional that this copies the 'done' status from the previous item, rather than creating new items as `[ ]`?
masad-frost commented 2022-04-12 19:10:04 +02:00 (Migrated from github.com)
Copy link

Good catch, I guess it should be unchecked

Good catch, I guess it should be unchecked
marijnh commented 2022-04-12 22:43:32 +02:00 (Migrated from github.com)
Copy link

Looks good, thanks!

Looks good, thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-markdown!2
No description provided.