Fix commentTokens definition #3

Merged

cyanzhong merged 1 commit from patch-1 into main 2023-02-18 09:27:31 +01:00

Conversation 1 Commits 1 Files changed 1 +1 -1

cyanzhong commented 2023-02-18 09:25:14 +01:00 (Migrated from github.com)

Copy link

I am not sure if I understand this correctly, was this an oversight? Feel free to close this PR if I am wrong.

Markdown does support comments by inheriting from HTML syntax, and the definition in lang-markdown seems to be correct.

However, it seems the declaration of defineLanguageFacet doesn't follow the languageData definition, which starts with a commentTokens scope.

It got comment features enabled after adding this.

I am not sure if I understand this correctly, was this an oversight? Feel free to close this PR if I am wrong. Markdown does support comments by inheriting from HTML syntax, and the definition in lang-markdown seems to be correct. However, it seems the declaration of `defineLanguageFacet` doesn't follow the `languageData` definition, which starts with a `commentTokens` scope. It got comment features enabled after adding this.

marijnh commented 2023-02-18 09:27:53 +01:00 (Migrated from github.com)

Copy link

Argh, indeed, that was entirely wrong. Thanks for spotting it.

Argh, indeed, that was entirely wrong. Thanks for spotting it.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/lang-markdown!3

No description provided.