codemirror/lang-markdown
1
0
Fork 0
Code Pull requests Activity

fix: typescript errors #4

Closed
maxswjeon wants to merge 2 commits from fix/typescript-errors into main
pull from: fix/typescript-errors
merge into: codemirror:main
Conversation 4 Commits 2 Files changed 4 +29 -17
maxswjeon commented 2023-10-28 05:00:45 +02:00 (Migrated from github.com)
Copy link

There are some typescript errors caused by untyped variables. Added types for local variables to resolve these errors.

There are some typescript errors caused by untyped variables. Added types for local variables to resolve these errors.
marijnh commented 2023-10-28 09:50:35 +02:00 (Migrated from github.com)
Copy link

Which version of TypeScript produces the errors?

Which version of TypeScript produces the errors?
maxswjeon commented 2023-10-28 09:52:54 +02:00 (Migrated from github.com)
Copy link

I'm using Typescript v5.2.2

I'm using Typescript v5.2.2
maxswjeon commented 2023-10-28 09:54:10 +02:00 (Migrated from github.com)
Copy link

The package built and exported does not have a typescript error. However, when I cloned the project to do some digging, I found out that it emits typescript error

The package built and exported does not have a typescript error. However, when I cloned the project to do some digging, I found out that it emits typescript error
marijnh commented 2023-10-29 22:42:51 +01:00 (Migrated from github.com)
Copy link

I get no such errors when I build this code with 5.2.2.

I get no such errors when I build this code with 5.2.2.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-markdown!4
No description provided.