Add commas to markdown config properties #8

Closed

cyanzhong wants to merge 1 commit from patch-1 into main

pull from: patch-1

merge into: codemirror:main

codemirror:main

Conversation 3 Commits 1 Files changed 1 +2 -2

cyanzhong commented 2025-10-22 16:38:40 +02:00 (Migrated from github.com)

Copy link

Just wanted to be consistent.

Just wanted to be consistent.

marijnh commented 2025-10-23 13:26:39 +02:00 (Migrated from github.com)

Copy link

I actually prefer to not use optional commas at all. See attached patch.

I actually prefer to not use optional commas at all. See attached patch.

👍 1

cyanzhong commented 2025-10-23 14:47:41 +02:00 (Migrated from github.com)

Copy link

Sounds good, but wait, I proposed changes in codemirror/lang-markdown and your change was done in lezer-parser/markdown 😂

Sounds good, but wait, I proposed changes in codemirror/lang-markdown and your change was done in lezer-parser/markdown 😂

marijnh commented 2025-10-23 14:55:34 +02:00 (Migrated from github.com)

Copy link

You're quite right. Trying again with a669e82

You're quite right. Trying again with a669e82

👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/lang-markdown!8

No description provided.