codemirror/lang-sql
1
0
Fork 0
Code Pull requests Activity

Parse semicolons inside BEGIN/END block without ending statement #10

Closed
sfc-gh-nchen wants to merge 1 commit from upstream-main into main
pull from: upstream-main
merge into: codemirror:main
Conversation 2 Commits 1 Files changed 3 +14 -4
sfc-gh-nchen commented 2022-11-09 21:04:15 +01:00 (Migrated from github.com)
Copy link

Right now, semicolons indicate the end of statement. If there is a BEGIN/END block with a semicolon, the outer statement is prematurely ended inside of the block.

Right now, semicolons indicate the end of statement. If there is a BEGIN/END block with a semicolon, the outer statement is prematurely ended inside of the block.
marijnh commented 2022-11-10 10:12:55 +01:00 (Migrated from github.com)
Copy link

I don't think this is a very promising way to solve this—it doesn't produce a meaningful syntactic structure for the content of the begin/end block, doesn't handle indentation, and doesn't cover similar constructs like if and loop. What kind of construct are you using the begin/end notation in?

I don't think this is a very promising way to solve this—it doesn't produce a meaningful syntactic structure for the content of the begin/end block, doesn't handle indentation, and doesn't cover similar constructs like `if` and `loop`. What kind of construct are you using the `begin`/`end` notation in?
sfc-gh-nchen commented 2022-11-15 20:05:47 +01:00 (Migrated from github.com)
Copy link

Closing since this varies so much between dialects

Closing since this varies so much between dialects

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-sql!10
No description provided.