Allow adding any types of objects for autcompletion. #15

Closed

adityatoshniwal wants to merge 1 commit from main into main

adityatoshniwal commented

2024-02-01 12:24:08 +01:00

(Migrated from github.com)

The changes are backward compatible. A new key objects is added which would behave just like schemas except with one more level to specify the object type. In schemas, it considers everything as table.

The changes are backward compatible. A new key `objects` is added which would behave just like schemas except with one more level to specify the object type. In schemas, it considers everything as table.

❤️ 1

marijnh commented

2024-02-12 19:22:15 +01:00

(Migrated from github.com)

I feel this further complicates an already messy system. Patch 5f9ea3b130 tries to clean up this whole interface to be more straightforward. Does it look like it would also solve your problem?

I feel this further complicates an already messy system. Patch 5f9ea3b1306c84529d9e73ea69213327336099d7 tries to clean up this whole interface to be more straightforward. Does it look like it would also solve your problem?

adityatoshniwal commented

2024-02-13 06:38:09 +01:00

(Migrated from github.com)

Hi @marijnh,
I thought you wish to keep the existing schema definition as is, so I didn't touch it.
The new changes looks perfect and is what I was looking for.
Thanks a lot.

Hi @marijnh, I thought you wish to keep the existing schema definition as is, so I didn't touch it. The new changes looks perfect and is what I was looking for. Thanks a lot.

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/lang-sql!15

No description provided.

Rows
Columns