codemirror/lang-sql
1
0
Fork 0
Code Pull requests Activity

Added missing MSSQL keywords and built-in functions #19

Merged
rureirureirurei merged 3 commits from add-missing-tokens into main 2025-07-14 09:58:42 +02:00
Conversation 6 Commits 3 Files changed 1 +71 -3
rureirureirurei commented 2025-07-09 22:17:31 +02:00 (Migrated from github.com)
Copy link

Added missing MSSQL keywords and built-in functions

This PR addresses the missing keywords identified in issue #1585. I've added:

  • Core built-in functions
  • Additional data types
  • Lock-related keywords

Each addition includes a source URL for future reference and verification.

Questions for review:

  • Should I remove the documentation comments to keep the code cleaner? Since tokens rarely change, inline comments might be unnecessary.
  • Are there any additions that should be adjusted or removed?

The changes are ready for review - feedback welcome!

**Added missing MSSQL keywords and built-in functions** This PR addresses the missing keywords identified in [issue #1585](https://github.com/codemirror/dev/issues/1585). I've added: - Core built-in functions - Additional data types - Lock-related keywords Each addition includes a source URL for future reference and verification. **Questions for review:** - Should I remove the documentation comments to keep the code cleaner? Since tokens rarely change, inline comments might be unnecessary. - Are there any additions that should be adjusted or removed? The changes are ready for review - feedback welcome!
rureirureirurei commented 2025-07-09 22:20:05 +02:00 (Migrated from github.com)
Copy link

It's not clear from the diff view, but I haven't removed any currently existing tokens, only added new ones.

It's not clear from the diff view, but I haven't removed any currently existing tokens, only added new ones.
marijnh commented 2025-07-10 09:12:53 +02:00 (Migrated from github.com)
Copy link

It looks like you're not putting spaces at the start or end of string concatenated with +, which will cause words at the start and end of lines to be joined.

Also, these should be specified in lower case. There's an option to upcase keyword completions.

It looks like you're not putting spaces at the start or end of string concatenated with `+`, which will cause words at the start and end of lines to be joined. Also, these should be specified in lower case. There's an [option](https://github.com/codemirror/lang-sql/?tab=readme-ov-file#user-content-sqlconfig.uppercasekeywords) to upcase keyword completions.
rureirureirurei commented 2025-07-13 14:39:17 +02:00 (Migrated from github.com)
Copy link

Fixed those, thanks for your fast review. Crazy how I didn't see the spaces issue myself.

Fixed those, thanks for your fast review. Crazy how I didn't see the spaces issue myself.
marijnh commented 2025-07-14 10:16:03 +02:00 (Migrated from github.com)
Copy link

Thanks! Merged, and changed a bit to fit with the surrounding code style. Let me know if it works for you, the way it is now, and I can tag a release.

Thanks! Merged, and changed a bit to fit with the surrounding code style. Let me know if it works for you, the way it is now, and I can tag a release.
rureirureirurei commented 2025-07-28 10:51:11 +02:00 (Migrated from github.com)
Copy link

I have not recieved any more suggestions - can you tag a release?
Thanks

I have not recieved any more suggestions - can you tag a release? Thanks
marijnh commented 2025-07-28 11:12:24 +02:00 (Migrated from github.com)
Copy link

I've tagged version 6.9.1

I've tagged version 6.9.1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-sql!19
No description provided.