codemirror/lang-sql
1
0
Fork 0
Code Pull requests Activity

feat(export): Allow Exporting Complete Functions #2

Closed
mjantscher wants to merge 1 commit from chore/export into main
pull from: chore/export
merge into: codemirror:main
Conversation 3 Commits 1 Files changed 3 +5 -4
mjantscher commented 2021-09-28 21:44:03 +02:00 (Migrated from github.com)
Copy link

I'm looking to dynamically add config schema to the autocomplete.

I want to be able to know when a user has typed a "parent" as defined by the sourceContext method so that I can then make an api call before populating the schema table with the columns returned from the api.

I should be able to do that with easy access to the methods that are written in complete.ts

I'm looking to dynamically add config schema to the autocomplete. I want to be able to know when a user has typed a "parent" as defined by the `sourceContext` method so that I can then make an api call before populating the schema table with the columns returned from the api. I should be able to do that with easy access to the methods that are written in complete.ts
marijnh commented 2021-09-29 07:55:32 +02:00 (Migrated from github.com)
Copy link

I recommend you duplicate the logic required for this instead—it's not a lot, and I dislike exporting internals like this since it requires me to document them and lock them down forever.

I recommend you duplicate the logic required for this instead—it's not a lot, and I dislike exporting internals like this since it requires me to document them and lock them down forever.
mjantscher commented 2021-09-30 17:05:05 +02:00 (Migrated from github.com)
Copy link

@marijnh that works for me. I noticed that after upgrading to versions 0.19.x that the "schema" mapping no longer seems to work. It looks like the '.' is no longer being identified (resolveInner returns it as a Script) so that the parent is not matched. Is that something you see as well?

@marijnh that works for me. I noticed that after upgrading to versions 0.19.x that the "schema" mapping no longer seems to work. It looks like the `'.'` is no longer being identified (`resolveInner` returns it as a `Script`) so that the parent is not matched. Is that something you see as well?
marijnh commented 2021-10-08 08:45:25 +02:00 (Migrated from github.com)
Copy link

Seems to still work for me. Can you show how you're setting up your editor and what you're doing precisely?

Seems to still work for me. Can you show how you're setting up your editor and what you're doing precisely?

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-sql!2
No description provided.