Fix -- line comments for MariaSQL / MySQL #8

Merged

neon-dev merged 1 commit from patch-2 into main 2022-08-23 15:39:39 +02:00

Conversation 3 Commits 1 Files changed 1 +1 -1

neon-dev commented 2022-08-23 15:37:38 +02:00 (Migrated from github.com)

Copy link

The required space after two dashes was checked at the wrong index.

The required space after two dashes was checked at the wrong index.

FreeWall commented 2022-10-17 18:02:01 +02:00 (Migrated from github.com)

Copy link

@neon-dev
I think SQL comments with double dashes are still problematic, it detect comments only with double spaces after double dashes for me.
I'm using lang-sql v6.3.0, dialect MySQL.

select * from table; -- not parsed as comment
select * from table; --  parsed as comment

screenshot from codemirror:

@neon-dev I think SQL comments with double dashes are still problematic, it detect comments only with double spaces after double dashes for me. I'm using lang-sql v6.3.0, dialect MySQL. ```sql select * from table; -- not parsed as comment select * from table; -- parsed as comment ``` screenshot from codemirror: 

neon-dev commented 2022-10-17 18:04:55 +02:00 (Migrated from github.com)

Copy link

@FreeWall this fix has not been released yet.

@FreeWall this fix has not been released yet.

👍 1 👀 1

marijnh commented 2022-10-17 18:32:15 +02:00 (Migrated from github.com)

Copy link

My bad. Released 6.3.1

My bad. Released 6.3.1

❤️ 1

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/lang-sql!8

No description provided.