codemirror/legacy-modes
1
0
Fork 0
Code Pull requests Activity

Add legacy Pegjs support #10

Closed
siefkenj wants to merge 2 commits from main into main
pull from: main
merge into: codemirror:main
Conversation 3 Commits 2 Files changed 3 +130
siefkenj commented 2022-11-09 19:02:08 +01:00 (Migrated from github.com)
Copy link

This PR ports the PEGjs support from CodeMirror 5.

The CodeMirror 5 PEGjs file was rewritten in Typescript. Currently Rollup does not produce a pegjs.d.ts, but this could be changed. (I don't think it's needed since a pegjs.ts is present, but maybe it still is...).

This PR ports the PEGjs support from CodeMirror 5. The CodeMirror 5 PEGjs file was rewritten in Typescript. Currently Rollup does not produce a `pegjs.d.ts`, but this could be changed. (I don't think it's needed since a `pegjs.ts` is present, but maybe it still is...).
marijnh commented 2022-11-10 10:14:36 +01:00 (Migrated from github.com)
Copy link

I would prefer for this mode to be plain JavaScript like all the others so that we don't have to complicate the build system for it.

I would prefer for this mode to be plain JavaScript like all the others so that we don't have to complicate the build system for it.
siefkenj commented 2022-11-10 17:06:38 +01:00 (Migrated from github.com)
Copy link

Done. I have committed the compiled version and removed the original ts file.

Done. I have committed the compiled version and removed the original `ts` file.
marijnh commented 2022-11-10 17:17:29 +01:00 (Migrated from github.com)
Copy link

Redone in 79e682a to preserve coding style used in other modes.

Redone in 79e682a to preserve coding style used in other modes.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/legacy-modes!10
No description provided.