codemirror/legacy-modes
1
0
Fork 0
Code Pull requests Activity

Add Farsi characters to command detection #12

Closed
rezass wants to merge 1 commit from main into main
pull from: main
merge into: codemirror:main
Conversation 2 Commits 1 Files changed 1 +1 -1
rezass commented 2022-12-06 14:53:52 +01:00 (Migrated from github.com)
Copy link

In addition to Latin characters, packages like xetex enable users to have commands defined by e.g., Farsi characters. This pull request adds such characters to the list of characters that can form a command. This list requires extending to include all Arabic and maybe other language characters.

In addition to Latin characters, packages like xetex enable users to have commands defined by e.g., Farsi characters. This pull request adds such characters to the list of characters that can form a command. This list requires extending to include all Arabic and maybe other language characters.
marijnh commented 2022-12-06 15:00:20 +01:00 (Migrated from github.com)
Copy link

What if we just put \u00c0-\uffff there, rather than trying to special case all scripts? Or can you think of a non-ascii character that is commonly used to terminate a command name?

What if we just put `\u00c0-\uffff` there, rather than trying to special case all scripts? Or can you think of a non-ascii character that is commonly used to terminate a command name?
rezass commented 2022-12-06 15:09:32 +01:00 (Migrated from github.com)
Copy link

It makes sense to include everything and exclude the ones we don't need. For example, U+200E, U+200F, U+202B, and the rest of the RTL/LTR encoding characters should be excluded. Or not, as they are not visible, they won't change anything visually for the user.

It makes sense to include everything and exclude the ones we don't need. For example, U+200E, U+200F, U+202B, and the rest of the RTL/LTR encoding characters should be excluded. Or not, as they are not visible, they won't change anything visually for the user.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/legacy-modes!12
No description provided.