codemirror/legacy-modes
1
0
Fork 0
Code Pull requests Activity

Add types to exports field in package.json #15

Closed
blaumeise20 wants to merge 1 commit from main into main
pull from: main
merge into: codemirror:main
Conversation 4 Commits 1 Files changed 1 +1 -1
blaumeise20 commented 2023-09-12 14:54:30 +02:00 (Migrated from github.com)
Copy link

I could not manage to get this package working with Node16 module resolution in TypeScript, because apparently it "can't find the corresponding type definitions for ...". This PR should fix those issues.

I could not manage to get this package working with `Node16` module resolution in TypeScript, because apparently it "can't find the corresponding type definitions for ...". This PR should fix those issues.
marijnh commented 2023-09-12 15:16:22 +02:00 (Migrated from github.com)
Copy link

Did you verify that this made stuff resolve properly? (For example by editing the file in your node_modules.)

Did you verify that this made stuff resolve properly? (For example by editing the file in your node_modules.)
blaumeise20 commented 2023-11-14 08:12:59 +01:00 (Migrated from github.com)
Copy link

Sorry I completely forgot this, I will check it later.

Sorry I completely forgot this, I will check it later.
stof (Migrated from github.com) reviewed 2025-03-13 14:34:03 +01:00
package.json
@ -17,4 +17,3 @@
},
"type": "module",
"types": "dist/index.d.ts",
"module": "dist/index.js",
stof (Migrated from github.com) commented 2025-03-13 14:34:03 +01:00
Copy link

shouldn't this be lept if the module entry (on next line) is kept ?

shouldn't this be lept if the `module` entry (on next line) is kept ?
jbmichaels1984 (Migrated from github.com) requested changes 2025-09-30 13:03:15 +02:00
jbmichaels1984 (Migrated from github.com) left a comment
Copy link

Android 16 beta free

Android 16 beta free

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
jbmichaels1984
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/legacy-modes!15
No description provided.