codemirror/legacy-modes
1
0
Fork 0
Code Pull requests Activity

commonlisp: stop recognizing ] as closing bracket #17

Merged
qjqqyy merged 2 commits from patch-1 into main 2024-04-09 10:02:21 +02:00
Conversation 3 Commits 2 Files changed 1 +1 -1
qjqqyy commented 2024-03-22 03:45:44 +01:00 (Migrated from github.com)
Copy link

when ] appears in atoms, it's wrongly matched with (

in this sample

(x y z[1-3])

the ( is matched with ] because [ is disregarded

when ] appears in atoms, it's wrongly matched with ( in this sample ``` (x y z[1-3]) ``` the ( is matched with ] because [ is disregarded
marijnh commented 2024-03-22 08:34:30 +01:00 (Migrated from github.com)
Copy link

It looks like you want these to be part of a symbol, in your example. Wouldn't removing the tokenization of ] and including these in symbol characters be more appropriate then?

It looks like you want these to be part of a symbol, in your example. Wouldn't removing the tokenization of `]` and including these in symbol characters be more appropriate then?
qjqqyy commented 2024-04-09 05:41:41 +02:00 (Migrated from github.com)
Copy link

seems like they are already included in the symbol regex, so I just removed the ] clause

seems like they are already included in the symbol regex, so I just removed the `]` clause
marijnh commented 2024-04-09 10:02:34 +02:00 (Migrated from github.com)
Copy link

Thanks, that looks reasonable.

Thanks, that looks reasonable.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/legacy-modes!17
No description provided.