Fix: xquery multiline syntax highlighting #20

Closed

amaan-mohib wants to merge 1 commit from main into main

pull from: main

merge into: codemirror:main

Conversation 4 Commits 1 Files changed 1 +4 -1

amaan-mohib commented 2025-01-28 15:23:30 +01:00 (Migrated from github.com)

Copy link

When we define a multiline string in XQuery (with legacy mode extension), syntax highlighting breaks for subsequent lines.

When we define a multiline string in XQuery (with legacy mode extension), syntax highlighting breaks for subsequent lines.

amaan-mohib commented 2025-01-28 15:30:23 +01:00 (Migrated from github.com)

Copy link

Fixes #20

Fixes #20

marijnh commented 2025-01-28 16:27:08 +01:00 (Migrated from github.com)

Copy link

There was a lot wrong with the original code there. Attached patch cleans it up a bit, fixing this issue in the process.

There was *a lot* wrong with the original code there. Attached patch cleans it up a bit, fixing this issue in the process.

👍 1

amaan-mohib commented 2025-02-10 12:50:00 +01:00 (Migrated from github.com)

Copy link

Hey @marijnh, when can this fix be published on npm?

Hey @marijnh, when can this fix be published on npm?

marijnh commented 2025-02-12 11:11:30 +01:00 (Migrated from github.com)

Copy link

I've tagged @codemirror/legacy-modes 6.4.3

I've tagged @codemirror/legacy-modes 6.4.3

👍 1

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/legacy-modes!20

No description provided.