codemirror/lint
1
0
Fork 0
Code Pull requests Activity

Ensure that lint gutter tooltip is displayed underneath the gutter marker #5

Closed
hubgit wants to merge 2 commits from lint-gutter-tooltip-position into main
pull from: lint-gutter-tooltip-position
merge into: codemirror:main
Conversation 3 Commits 2 Files changed 1 +5 -3
hubgit commented 2022-02-25 14:03:57 +01:00 (Migrated from github.com)
Copy link

The aim here is to ensure that a lint gutter tooltip is displayed directly underneath the gutter marker when line wrapping is enabled (where the marker is positioned in the vertical centre of the "visual line"), rather than underneath the first line.

diagnostic marker on a short line:

image

diagnostic marker on a long line:

image
The aim here is to ensure that a lint gutter tooltip is displayed directly underneath the gutter marker when line wrapping is enabled (where the marker is positioned in the vertical centre of the "visual line"), rather than underneath the first line. diagnostic marker on a short line: <img width="590" alt="image" src="https://user-images.githubusercontent.com/14294/155710230-f02f616c-2058-4a16-a47f-57d4ba4fb47f.png"> diagnostic marker on a long line: <img width="590" alt="image" src="https://user-images.githubusercontent.com/14294/155710278-c316b52f-de88-4c17-a81c-e37a0d9c02d9.png">
hubgit commented 2022-02-25 14:04:07 +01:00 (Migrated from github.com)
Copy link

For some reason the tooltip still isn't being positioned correctly when there's no room for it beneath the marker at the bottom of the page, but I suspect that's an issue in the tooltip extension rather than the positioning in the lint extension.

For some reason the tooltip still isn't being positioned correctly when there's no room for it beneath the marker at the bottom of the page, but I suspect that's an issue in the tooltip extension rather than the positioning in the lint extension.
marijnh commented 2022-02-25 15:46:50 +01:00 (Migrated from github.com)
Copy link

This is getting terribly hacky. Do attached patches look reasonable to you as an alternative?

This is getting terribly hacky. Do attached patches look reasonable to you as an alternative?
hubgit commented 2022-02-25 16:48:15 +01:00 (Migrated from github.com)
Copy link

The combination of those two patches seems to work perfectly - thanks! I'll close this PR.

The combination of those two patches seems to work perfectly - thanks! I'll close this PR.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lint!5
No description provided.