Handle empty arrays in jumpToOrigin #1

Closed

JeanJPNM wants to merge 1 commit from fix-jump-to-origin-empty-arrays into main

pull from: fix-jump-to-origin-empty-arrays

merge into: codemirror:main

codemirror:main

Conversation 1 Commits 1 Files changed 1 +2 -1

JeanJPNM commented 2025-09-13 20:07:04 +02:00 (Migrated from github.com)

Copy link

Fixes jumpToOrigin to graciously handle empty arrays returned from textDocument/definition and friends. Originially the function crashed with TypeError: can't access property "uri", loc is undefined.

Fixes `jumpToOrigin` to graciously handle empty arrays returned from `textDocument/definition` and friends. Originially the function crashed with `TypeError: can't access property "uri", loc is undefined`.

👍 1

marijnh commented 2026-04-07 20:40:50 +02:00 (Migrated from github.com)

Copy link

I was somehow not subscribed to this repository, and didn't see this PR. Sorry about the slowness. Merged as d640c15

I was somehow not subscribed to this repository, and didn't see this PR. Sorry about the slowness. Merged as d640c15

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/lsp-client!1

No description provided.