codemirror/lsp-client
1
0
Fork 0
Code Pull requests Activity

Update $/cancelRequest to send object #3

Merged
alissa-tung merged 1 commit from patch-1 into main 2026-04-07 20:45:10 +02:00
Conversation 1 Commits 1 Files changed 1 +1 -1
alissa-tung commented 2026-02-01 16:45:18 +01:00 (Migrated from github.com)
Copy link

I am not sure the code formatting that you prefer, I learned from the following existed code:

this.notification<lsp.DidCloseTextDocumentParams>("textDocument/didClose", {textDocument: {uri}})

This fix addresses the LSP:

interface CancelParams {
	/**
	 * The request id to cancel.
	 */
	id: integer | string;
}

See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#cancelRequest

I am not sure the code formatting that you prefer, I learned from the following existed code: ```ts this.notification<lsp.DidCloseTextDocumentParams>("textDocument/didClose", {textDocument: {uri}}) ``` --- This fix addresses the LSP: ```ts interface CancelParams { /** * The request id to cancel. */ id: integer | string; } ``` See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#cancelRequest
marijnh commented 2026-04-07 20:45:35 +02:00 (Migrated from github.com)
Copy link

Sorry about the slow turnaround. I wasn't receiving notifications for this repository, somehow. Merged this now.

Sorry about the slow turnaround. I wasn't receiving notifications for this repository, somehow. Merged this now.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lsp-client!3
No description provided.