Handle backslash escapes in snippet completion text #6

Closed

ondrejmirtes wants to merge 0 commits from ondrejmirtes/lsp-client:snippet-escapes into main

ondrejmirtes commented

2026-05-21 20:38:03 +02:00

First-time contributor

Snippet completion items (insertTextFormat: Snippet) carry LSP snippets, which
use \$, \} and \\ for literal characters. serverCompletion translated the $1
tab stops to ${1} but passed the escapes through to CodeMirror's snippet
parser unchanged, so e.g. a method completion with insertText "add(${1:\$x})$0"
came out as add(\$x) instead of add($x).

This unescapes \$, \} and \\ in the snippet translation, and adds a test.

Snippet completion items (insertTextFormat: Snippet) carry LSP snippets, which use `\$`, `\}` and `\\` for literal characters. serverCompletion translated the `$1` tab stops to `${1}` but passed the escapes through to CodeMirror's snippet parser unchanged, so e.g. a method completion with insertText `"add(${1:\$x})$0"` came out as `add(\$x)` instead of `add($x)`. This unescapes `\$`, `\}` and `\\` in the snippet translation, and adds a test.

ondrejmirtes added 1 commit

2026-05-21 20:38:03 +02:00

Handle backslash escapes in snippet completion text 1371912bbf

The insertText of a snippet completion is an LSP snippet, where \$, \} and \\
are escapes for literal characters. We translated $1 tab stops to ${1} but
left the escapes alone and handed them to CodeMirror's snippet parser, which
doesn't understand them. So a completion like add(${1:\$x})$0 was inserted as
add(\$x) instead of add($x). Unescape \$, \} and \\ as well.