Add search config option to not match case when search panel is opened #4

Merged

marcuswestin merged 2 commits from add-search-config-to-not-match-case into main 2021-09-06 14:32:36 +02:00

Conversation 4 Commits 2 Files changed 1 +11 -2

marcuswestin commented 2021-09-04 17:43:39 +02:00 (Migrated from github.com)

Copy link

When opening the search panel, I want to be able to have "match case" not active.

This patch adds a search config option to do so.

When opening the search panel, I want to be able to have "match case" not active. This patch adds a search config option to do so.

marijnh (Migrated from github.com) reviewed 2021-09-06 09:43:32 +02:00

src/search.ts

marijnh (Migrated from github.com) commented 2021-09-06 09:43:32 +02:00

Copy link

I think you want ?? instead of || here, so that if fallback is given its setting is preserved.

I think you want `??` instead of `||` here, so that if `fallback` is given its setting is preserved.

marcuswestin (Migrated from github.com) reviewed 2021-09-06 14:19:27 +02:00

src/search.ts

marcuswestin (Migrated from github.com) commented 2021-09-06 14:19:27 +02:00

Copy link

Yes! ?? is right.

It's such a nice operator :)

Yes! ?? is right. It's such a nice operator :)

marijnh commented 2021-09-06 14:33:32 +02:00 (Migrated from github.com)

Copy link

Thanks!

Thanks!

👍 1

marcuswestin commented 2021-09-06 14:58:28 +02:00 (Migrated from github.com)

Copy link

Thank you!

Looking forward to making more contributions 👍

Thank you! Looking forward to making more contributions 👍

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/search!4

No description provided.