codemirror/search
1
0
Fork 1
Code Issues Pull requests Activity

Set explicitly the type button for buttons. #6

Merged
iamdey merged 1 commit from fix_button_type into main 2021-09-16 10:39:06 +02:00
Conversation 4 Commits 1 Files changed 1 +2 -2
iamdey commented 2021-09-15 23:25:55 +02:00 (Migrated from github.com)
Copy link

When the editor is in a form the search buttons will submit the form.

When the editor is in a `form` the search buttons will submit the form.
marijnh commented 2021-09-16 00:11:05 +02:00 (Migrated from github.com)
Copy link

Good idea. There's also the close button, which isn't created through the button function.

And don't put your release note in the changelog—put it in a FIX: ... line in the commit message.

Good idea. There's also the close button, which isn't created through the `button` function. And don't put your release note in the changelog—put it in a `FIX: ...` line in the commit message.
marijnh commented 2021-09-16 10:14:16 +02:00 (Migrated from github.com)
Copy link

Thanks. Just one more nitpick: Please use double quoted strings.

Thanks. Just one more nitpick: Please use double quoted strings.
👍 1
iamdey commented 2021-09-16 10:20:54 +02:00 (Migrated from github.com)
Copy link

Woops I missed this close button. fixed.

Also is it possible to release a patch version for 0.18?

The version 0.19 of codemirror works fine in the browser but for an obscure reason it makes the CI stuck in an infinite loop (jest + testing-library). I'll come with a more detailed investigation on your discuss website as soon as possible.

Woops I missed this close button. fixed. --- Also is it possible to release a patch version for 0.18? The version 0.19 of codemirror works fine in the browser but for an obscure reason it makes the CI stuck in an infinite loop (jest + testing-library). I'll come with a more detailed investigation on your discuss website as soon as possible.
marijnh commented 2021-09-16 10:39:32 +02:00 (Migrated from github.com)
Copy link

Sorry, I'm not backporting changes to previous releases at this point.

Sorry, I'm not backporting changes to previous releases at this point.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/search!6
No description provided.