codemirror/state
1
0
Fork 0
Code Issues Pull requests Activity

fix: mapPos documentation #6

Merged
nathanlesage merged 1 commit from patch-1 into main 2025-08-01 18:38:38 +02:00
Conversation 1 Commits 1 Files changed 1 +5 -5
nathanlesage commented 2025-08-01 18:34:53 +02:00 (Migrated from github.com)
Copy link

I just found a minor error in the documentation for the mapPos function. Specifically, the documentation for the usage of the assoc parameter did not match the implementation. The old documentation stated that the assoc was binarized to zero or negative and positive. However, in the function body, you only check for assoc < 0, effectively binarizing to negative, and zero or positive.

This adapts the documentation for mapPos to truthfully report the usage of the assoc parameter.

I just found a minor error in the documentation for the `mapPos` function. Specifically, the documentation for the usage of the `assoc` parameter did not match the implementation. The old documentation stated that the `assoc` was binarized to zero or negative and positive. However, in the function body, you only check for `assoc < 0`, effectively binarizing to negative, and zero or positive. This adapts the documentation for `mapPos` to truthfully report the usage of the `assoc` parameter.
marijnh commented 2025-08-01 18:38:46 +02:00 (Migrated from github.com)
Copy link

Thank you for spotting that!

Thank you for spotting that!
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/state!6
No description provided.