codemirror/theme-one-dark
1
0
Fork 0
Code Pull requests Activity

refactor(one-dark): export all theme colors for reuse is needed #3

Closed
bRRRITSCOLD wants to merge 5 commits from main into main
pull from: main
merge into: codemirror:main
Conversation 7 Commits 5 Files changed 2 +45 -45
bRRRITSCOLD commented 2022-07-30 01:32:48 +02:00 (Migrated from github.com)
Copy link

Export theme colors for reuse by down stream users to match said theme colors/reuse of said theme colors

Export theme colors for reuse by down stream users to match said theme colors/reuse of said theme colors
bRRRITSCOLD commented 2022-07-30 01:33:34 +02:00 (Migrated from github.com)
Copy link

@marijnh If you have some time - I just want to reuse the theme color for some things in an app, don't want to use a forked version or keep local colors up to date with this repo

@marijnh If you have some time - I just want to reuse the theme color for some things in an app, don't want to use a forked version or keep local colors up to date with this repo
marijnh commented 2022-08-04 12:05:44 +02:00 (Migrated from github.com)
Copy link
  1. We're definitely not breaking backwards compat or bumping the major version of any of these packages.
  2. This looks entirely broken and untested so it's really hard to take it seriously.
1. We're definitely not breaking backwards compat or bumping the major version of any of these packages. 2. This looks entirely broken and untested so it's really hard to take it seriously.
bRRRITSCOLD commented 2022-08-04 12:08:52 +02:00 (Migrated from github.com)
Copy link
  1. @marijnh how does this break backwards compat? The things that are exported and renamed now were never exported to begin with, so no one would be using them in their code, therefore there is no possible way we break anyone.
  2. I will gladly update tests now! :)
1. @marijnh how does this break backwards compat? The things that are exported and renamed now were never exported to begin with, so no one would be using them in their code, therefore there is no possible way we break anyone. 2. I will gladly update tests now! :)
bRRRITSCOLD commented 2022-08-04 12:10:57 +02:00 (Migrated from github.com)
Copy link
  1. @marijnh you have no tests.... It works completely fine for me locally, so for "tested" idk what more your repo requires, your whole codebase is "untested" isn't it?
2. @marijnh you have no tests.... It works completely fine for me locally, so for "tested" idk what more your repo requires, your whole codebase is "untested" isn't it?
marijnh commented 2022-08-04 12:14:12 +02:00 (Migrated from github.com)
Copy link

how does this break backwards compat?

You're the one who moved it to version 7.0.0.

I'm not talking about automated tests. I'm talking about the fact that you're using CSS properties like one-dark-background-color, which are definitely not something the browser will use.

> how does this break backwards compat? You're the one who moved it to version 7.0.0. I'm not talking about automated tests. I'm talking about the fact that you're using CSS properties like `one-dark-background-color`, which are definitely not something the browser will use.
bRRRITSCOLD commented 2022-08-04 12:17:20 +02:00 (Migrated from github.com)
Copy link

backgroundColor to oneDarkBackgroundColor is clearly a mistake on my end.... Its an obvious "ctrl + f" mistake, fixing now.

As for 7.0.0 would your suggestion to be just a minor bump? 6.1.0? 6.0.1?

> `backgroundColor` to `oneDarkBackgroundColor` is clearly a mistake on my end.... Its an obvious "ctrl + f" mistake, fixing now. As for `7.0.0` would your suggestion to be just a minor bump? `6.1.0`? `6.0.1`?
marijnh commented 2022-08-04 16:25:19 +02:00 (Migrated from github.com)
Copy link

Would attached patch work as a replacement for this?

Would attached patch work as a replacement for this?
👍 1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/theme-one-dark!3
No description provided.