codemirror/view
1
0
Fork 0
Code Pull requests Activity

Account for scale when updating the gutter height #63

Merged
viorgu merged 1 commit from fix-gutter-scale into main 2024-02-20 11:06:09 +01:00
Conversation 1 Commits 1 Files changed 1 +3 -1
viorgu commented 2024-02-20 10:53:35 +01:00 (Migrated from github.com)
Copy link

The gutter ends up at an incorrect height when the editor is scaled after it is created.

codemirror-gutter-issue

The issue seems to be that scaleY is used when calculating the gutter height in the constructor but not in subsequent view updates.

The gutter ends up at an incorrect height when the editor is scaled after it is created. <img width="307" alt="codemirror-gutter-issue" src="https://github.com/codemirror/view/assets/1153033/ab7b8e02-6224-4b5f-8537-d16674e2b366"> The issue seems to be that `scaleY` is used when calculating the gutter height in the constructor but not in subsequent view updates.
marijnh commented 2024-02-20 11:06:21 +01:00 (Migrated from github.com)
Copy link

Thanks for spotting that!

Thanks for spotting that!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/view!63
No description provided.