codemirror/view
1
0
Fork 0
Code Issues Pull requests Activity

#1430 Avoid exceptions when running in the headless browser mode #68

Closed
ievgennaida wants to merge 2 commits from main into main
pull from: main
merge into: codemirror:main
Conversation 3 Commits 2 Files changed 2 +4 -4
ievgennaida commented 2024-08-26 15:49:16 +02:00 (Migrated from github.com)
Copy link

Hi @marijnh,

I've added some checks for undefined values to prevent exceptions occuring when partial browser functionality used during headless Edge runs.

These checks don't change any of the existing logic. My test running smoothly with these fixes.
I would greatly appreciate it if these changes could be released asap.

Thank you!

https://github.com/codemirror/dev/issues/1430

Hi @marijnh, I've added some checks for undefined values to prevent exceptions occuring when partial browser functionality used during headless Edge runs. These checks don't change any of the existing logic. My test running smoothly with these fixes. I would greatly appreciate it if these changes could be released asap. Thank you! https://github.com/codemirror/dev/issues/1430
marijnh commented 2024-08-26 17:26:06 +02:00 (Migrated from github.com)
Copy link

Sorry, no. I'm willing to add workaround for popular browsers, but not for obscure test runners.

Sorry, no. I'm willing to add workaround for popular browsers, but not for obscure test runners.
ievgennaida commented 2024-08-26 17:55:38 +02:00 (Migrated from github.com)
Copy link

Sorry, no. I'm willing to add workaround for popular browsers, but not for obscure test runners.

Sorry to hear.
I would like to try to insist to check this again while this is not obscure browsers and this direct usecase when people are performing testing in the ci/cd pipelines.

The function that is fixed used for the printing without any check is deprecated , and this is really obscure.

Please make a great tool usable.

> Sorry, no. I'm willing to add workaround for popular browsers, but not for obscure test runners. Sorry to hear. I would like to try to insist to check this again while this is **not** obscure browsers and this direct usecase when people are performing testing in the ci/cd pipelines. The function that is fixed used for the printing without any check is **deprecated** , and this is really obscure. Please make a great tool usable.
marijnh commented 2024-08-26 18:03:13 +02:00 (Migrated from github.com)
Copy link

The function that is fixed used for the printing without any check is deprecated , and this is really obscure.

It's only used when the platform doesn't support MediaQueryList.removeEventListener, which is standard and supported on all browsers that have MediaQueryList.

> The function that is fixed used for the printing without any check is deprecated , and this is really obscure. It's only used when the platform doesn't support `MediaQueryList.removeEventListener`, which is standard and supported on all browsers that have `MediaQueryList`.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/view!68
No description provided.