lezer/common
1
0
Fork 0
Code Issues Pull requests Activity

hostfix premature stop of overlay in mixedParse #10

Closed
rguryanov wants to merge 2 commits from hostfix-overlay-parse into main
pull from: hostfix-overlay-parse
merge into: lezer:main
Conversation 5 Commits 2 Files changed 2 +10 -2
rguryanov commented 2025-03-21 01:05:45 +01:00 (Migrated from github.com)
Copy link

materialize create one more level of nesting
we need to add depth to active overlay for going backwards

materialize create one more level of nesting we need to add depth to active overlay for going backwards
marijnh commented 2025-03-21 09:10:22 +01:00 (Migrated from github.com)
Copy link

Do you have an example script that shows this issue causing a problem?

Do you have an example script that shows this issue causing a problem?
rguryanov commented 2025-03-21 12:43:13 +01:00 (Migrated from github.com)
Copy link

https://github.com/rguryanov/lezer-overlay-problem
reproduction repo with typescript app

https://github.com/rguryanov/lezer-overlay-problem reproduction repo with typescript app
marijnh commented 2025-03-21 15:47:44 +01:00 (Migrated from github.com)
Copy link

Thanks, that helped reproduce. The patch looks good. Merged as 4e13beb.

Thanks, that helped reproduce. The patch looks good. Merged as 4e13beb.
marijnh commented 2025-03-25 09:11:49 +01:00 (Migrated from github.com)
Copy link

(If you've had a chance to test this in production, let me know. I'm slightly worried it could regress something, but I'll cut a release if you can confirm you didn't run into issues.)

(If you've had a chance to test this in production, let me know. I'm slightly worried it could regress something, but I'll cut a release if you can confirm you didn't run into issues.)
rguryanov commented 2025-03-26 21:50:56 +01:00 (Migrated from github.com)
Copy link

Ok, i will let you known
But we don't have much of mixed languages
And QA testing of that feature will be going to the one of the next versions, so i don't have any specific deadlines

Ok, i will let you known But we don't have much of mixed languages And QA testing of that feature will be going to the one of the next versions, so i don't have any specific deadlines

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/common!10
No description provided.