lezer/common
1
0
Fork 0
Code Issues Pull requests Activity

Expose NodeProp.id for debugging Tree.propValues #9

Closed
not-my-profile wants to merge 2 commits from node-prop-id into main
pull from: node-prop-id
merge into: lezer:main
Conversation 1 Commits 2 Files changed 1 +4 -3
not-my-profile commented 2024-10-04 07:44:46 +02:00 (Migrated from github.com)
Copy link

Note that I've classified the first commit that changes the type of Tree.propValues as a breaking change since it could break the TypeScript compilation of an API user.

Note that I've classified the first commit that changes the type of `Tree.propValues` as a breaking change since it could break the TypeScript compilation of an API user.
marijnh commented 2024-10-04 19:24:35 +02:00 (Migrated from github.com)
Copy link

I don't feel specific debugging scenarios justify this kind of complication of the public interface and docs. You can already access the props of a node as normal via .prop(). The IDs aren't something client code should know about.

I don't feel specific debugging scenarios justify this kind of complication of the public interface and docs. You can already access the props of a node as normal via `.prop()`. The IDs aren't something client code should know about.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/common!9
No description provided.