lezer/css
1
0
Fork 0
Code Issues Pull requests Activity

Missing pseudo-class functions #1

Closed
NiedziolkaMichal wants to merge 1 commit from patch-1 into main
pull from: patch-1
merge into: lezer:main
Conversation 3 Commits 1 Files changed 1 +1 -1
NiedziolkaMichal commented 2022-09-30 14:38:42 +02:00 (Migrated from github.com)
Copy link

I added missing pseudo-classes which are supposed to be used with an argument.
Pseudo-class :host can be used with or without them.

I added missing pseudo-classes which are supposed to be used with an argument. Pseudo-class :host can be used [with](https://developer.mozilla.org/en-US/docs/Web/CSS/:host) or [without](https://developer.mozilla.org/en-US/docs/Web/CSS/:host_function) them.
marijnh commented 2022-10-07 08:39:35 +02:00 (Migrated from github.com)
Copy link

host doesn't seem to accept arguments, so it doesn't need to be explicitly handled. where and is expect a selector, so they should be handled in UnaryQuery. not is already handled there. Does attached patch work for you?

`host` doesn't seem to accept arguments, so it doesn't need to be explicitly handled. `where` and `is` expect a selector, so they should be handled in `UnaryQuery`. `not` is already handled there. Does attached patch work for you?
NiedziolkaMichal commented 2022-10-07 14:02:11 +02:00 (Migrated from github.com)
Copy link

UnaryQuery { @specialize[@name=UnaryQueryOp]<identifier, "not" | "only" | "is" | "where"> query } | doesn't seem to be right place for is or where, because UnaryQuery handles following case:

@media only not (width: 20px)

In this context keywords only and not are acceptable, but is and where are not. Also keyword only is acceptable only in media queries, there is no such pseudo-class or pseudo-element.

`UnaryQuery { @specialize[@name=UnaryQueryOp]<identifier, "not" | "only" | "is" | "where"> query } |` doesn't seem to be right place for `is` or `where`, because UnaryQuery handles following case: ```css @media only not (width: 20px) ``` In this context keywords `only` and `not` are acceptable, but `is` and `where` are not. Also keyword `only` is acceptable only in media queries, there is no such pseudo-class or pseudo-element.
marijnh commented 2022-10-09 19:00:39 +02:00 (Migrated from github.com)
Copy link

You are right, those don't belong there (and were in fact already parsed correctly by the existing code).

You are right, those don't belong there (and were in fact already parsed correctly by the existing code).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/css!1
No description provided.