lezer/css
1
0
Fork 0
Code Issues Pull requests Activity

Add timeline range support to keyframe selectors #6

Closed
ergunsh wants to merge 1 commit from add-timeline-range-support into main
pull from: add-timeline-range-support
merge into: lezer:main
Conversation 4 Commits 1 Files changed 2 +54 -1
ergunsh commented 2023-05-15 10:56:42 +02:00 (Migrated from github.com)
Copy link

This is being introduced with scroll animations

Drive by fix: a keyframe block might contain multiple keyframe selectors according to here

This is being introduced with [scroll animations](https://www.w3.org/TR/scroll-animations-1/#named-range-keyframes) Drive by fix: a keyframe block might contain multiple keyframe selectors according to [here](https://www.w3.org/TR/css-animations-1/#keyframes)
ergunsh commented 2023-05-15 10:58:36 +02:00 (Migrated from github.com)
Copy link

Hello hello @marijnh! :)

Can you take a look at this PR when you have time? I'm also not sure about the naming conventions in the grammar file so please feel free to suggest other names too. cc @bmeurer

Hello hello @marijnh! :) Can you take a look at this PR when you have time? I'm also not sure about the naming conventions in the grammar file so please feel free to suggest other names too. cc @bmeurer
marijnh commented 2023-05-15 11:45:52 +02:00 (Migrated from github.com)
Copy link

Does attached patch look like it addresses your requirements? I decided to not use the kw<...>-style specialization here, since it'll make it impossible for these words to be used as identifiers in other contexts.

Does attached patch look like it addresses your requirements? I decided to not use the `kw<...>`-style specialization here, since it'll make it impossible for these words to be used as identifiers in other contexts.
ergunsh commented 2023-05-15 12:24:57 +02:00 (Migrated from github.com)
Copy link

Yep, that looks good to me; thanks for the quick fix! :)

Yep, that looks good to me; thanks for the quick fix! :)
marijnh commented 2023-05-15 12:30:59 +02:00 (Migrated from github.com)
Copy link

I've tagged 1.1.2 but npm seems to be having an outage and won't let me upload it. Will try again later.

I've tagged 1.1.2 but npm seems to be having an outage and won't let me upload it. Will try again later.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/css!6
No description provided.