lezer/html
1
0
Fork 0
Code Issues Pull requests Activity

Align unquoted attribute value syntax with the HTML spec. #6

Merged
bmeurer merged 1 commit from unquotedAttributeValues into main 2022-11-18 08:05:32 +01:00
Conversation 3 Commits 1 Files changed 2 +15 -2
bmeurer commented 2022-11-17 09:47:14 +01:00 (Migrated from github.com)
Copy link

According to the HTML spec1 the unquoted attribute values can contain slashes, and basically only forbid ASCII whitespace, quotation characters, equals, and <>. This fixes the token regex to be aligned with the HTML specification here.

Bug: https://crbug.com/1385661

According to the HTML spec[^1] the unquoted attribute values can contain slashes, and basically only forbid ASCII whitespace, quotation characters, equals, and <>. This fixes the token regex to be aligned with the HTML specification here. [^1]: https://html.spec.whatwg.org/multipage/syntax.html#unquoted Bug: https://crbug.com/1385661
marijnh commented 2022-11-17 15:49:44 +01:00 (Migrated from github.com)
Copy link

Any reason you're using hex codes rather than the more readable and shorter escapes like \t in there?

Any reason you're using hex codes rather than the more readable and shorter escapes like `\t` in there?
bmeurer commented 2022-11-17 16:51:17 +01:00 (Migrated from github.com)
Copy link

Any reason you're using hex codes rather than the more readable and shorter escapes like \t in there?

Was easiest to not make a mistake when going through the HTML spec. I've updated the patch to a minimal delta.

> Any reason you're using hex codes rather than the more readable and shorter escapes like `\t` in there? Was easiest to not make a mistake when going through the HTML spec. I've updated the patch to a minimal delta.
marijnh commented 2022-11-18 08:06:21 +01:00 (Migrated from github.com)
Copy link

Thanks, merged.

Thanks, merged.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/html!6
No description provided.