Add types to "exports" #22

Closed

NullVoxPopuli wants to merge 1 commit from patch-1 into main

pull from: patch-1

merge into: lezer:main

lezer:main

Conversation 2 Commits 1 Files changed 1 +2 -1

NullVoxPopuli commented 2023-07-02 17:16:45 +02:00 (Migrated from github.com)

Copy link

Resolves https://github.com/lezer-parser/javascript/issues/21

I tested this change here, via patch: https://github.com/NullVoxPopuli/limber/pull/1050/commits/33242070d07eb0169f6ef809f87cd438c64133a5

Resolves https://github.com/lezer-parser/javascript/issues/21 I tested this change here, via patch: https://github.com/NullVoxPopuli/limber/pull/1050/commits/33242070d07eb0169f6ef809f87cd438c64133a5

marijnh commented 2023-07-03 10:49:08 +02:00 (Migrated from github.com)

Copy link

Does 2540cbedbf fix this for you?

Does 2540cbedbf5f9ccb8169aae7992bf5376fd170e0 fix this for you?

NullVoxPopuli commented 2023-07-04 03:48:19 +02:00 (Migrated from github.com)

Copy link

it does, thanks.

Also, found this tool helpful: https://arethetypeswrong.github.io/?p=%40lezer%2Fjavascript%401.4.4

they have a CLI, too, so this sort of config can be added to CI

it does, thanks. Also, found this tool helpful: https://arethetypeswrong.github.io/?p=%40lezer%2Fjavascript%401.4.4 they have a CLI, too, so this sort of config can be added to CI

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lezer/javascript!22

No description provided.