Update codemirror and lezer

It's already in the repo: https://github.com/lezer-parser/json/tree/master/docs
It will break the demo page when it is removed or am I missing something?

It's already in the repo: https://github.com/lezer-parser/json/tree/master/docs It will break the demo page when it is removed or am I missing something?

marijnh commented

2020-09-21 10:12:39 +02:00

(Migrated from github.com)

Ah, sorry, github's diff showed this with only green dots, leading me to assume it was newly added.

I do think keeping build output in the repository is a bad idea, but I'll let @satchmorun decide how to merge this.

Ah, sorry, github's diff showed this with only green dots, leading me to assume it was newly added. I do think keeping build output in the repository is a bad idea, but I'll let @satchmorun decide how to merge this.

PhilippRaab commented

2020-09-21 10:55:03 +02:00

(Migrated from github.com)

I agree, I will remove the build output. When @satchmorun decides to keep the build in the repo, he can add it later again.

satchmorun commented

2020-09-21 17:25:58 +02:00

(Migrated from github.com)

I do think keeping build output in the repository is a bad idea, but I'll let @satchmorun decide how to merge this.

I agree, I will remove the build output. When @satchmorun decides to keep the build in the repo, he can add it later again.

My thinking at the time was that the docs directory output was a useful thing to be able to click around to see how the thing actually worked.

I'm assuming that eventually something like that will be possible on the CodeMirror docs site, which would render this (and the associated github pages site) redundant.

And the real use of it is for development anyway, so I'm happy to remove the build output and the github pages site. (NOTE: It seems to be possible to actually use a build step to build a pages site, but feels like more effort than it's worth at the moment).

All that's to say: this is good with me 👍. Thanks for the PR!

> I do think keeping build output in the repository is a bad idea, but I'll let @satchmorun decide how to merge this. > I agree, I will remove the build output. When @satchmorun decides to keep the build in the repo, he can add it later again. My thinking at the time was that the `docs` directory output was a useful thing to be able to click around to see how the thing actually worked. I'm assuming that eventually something like that will be possible on the CodeMirror docs site, which would render this (and the associated github pages site) redundant. And the real use of it is for development anyway, so I'm happy to remove the build output and the github pages site. (NOTE: [It seems to be possible to actually use a build step to build a pages site](https://github.com/marketplace/actions/deploy-to-github-pages), but feels like more effort than it's worth at the moment). All that's to say: this is good with me 👍. Thanks for the PR!

Rows
Columns

Update codemirror and lezer #2