lezer/json
1
0
Fork 0
Code Issues Pull requests Activity

Use esm package with mocha #3

Closed
PhilippRaab wants to merge 1 commit from fix-test-script into master
pull from: fix-test-script
merge into: lezer:master
Conversation 5 Commits 1 Files changed 1 +2 -1
PhilippRaab commented 2020-09-17 12:36:02 +02:00 (Migrated from github.com)
Copy link
No description provided.
satchmorun commented 2020-09-21 17:34:02 +02:00 (Migrated from github.com)
Copy link

Now that the other 2 PRs are merged, do you mind squashing this down? Seems that this PR can now just be the one commit "Use esm package with mocha".

Now that the other 2 PRs are merged, do you mind squashing this down? Seems that this PR can now just be the one commit "Use esm package with mocha".
👍 1
marijnh commented 2020-09-23 09:59:41 +02:00 (Migrated from github.com)
Copy link

What does this fix? With recent Mocha versions ES module tests run fine without loading esm

What does this fix? With recent Mocha versions ES module tests run fine without loading esm
PhilippRaab commented 2020-09-23 10:39:46 +02:00 (Migrated from github.com)
Copy link

I get following error when not using esm:

image

I get following error when not using esm: ![image](https://user-images.githubusercontent.com/11347054/93988476-0a195280-fd89-11ea-9001-5a8514df1c25.png)
marijnh commented 2020-09-23 10:56:37 +02:00 (Migrated from github.com)
Copy link

With Mocha 8? Which node version are you running?

With Mocha 8? Which node version are you running?
PhilippRaab commented 2020-09-23 11:49:11 +02:00 (Migrated from github.com)
Copy link

It's working now. I had to update node to version > 12.11 (see: https://github.com/mochajs/mocha/pull/4038).

It's working now. I had to update node to version > 12.11 (see: https://github.com/mochajs/mocha/pull/4038).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/json!3
No description provided.