Fix: process.env may not exist #61

Closed

yunyuyuan wants to merge 1 commit from patch-1 into main

pull from: patch-1

merge into: lezer:main

lezer:main

Conversation 2 Commits 1 Files changed 1 +1 -1

yunyuyuan commented 2022-05-04 09:52:30 +02:00 (Migrated from github.com)

Copy link

Sometimes process != 'undefined' but process.env == undefined,in a framework Nuxt3. Like this:

Error:

Anyhow,maybe we should check whether env exists in this place.

Sometimes `process != 'undefined'` but `process.env == undefined`,in a framework [Nuxt3](https://v3.nuxtjs.org/). Like this:  Error:  Anyhow,maybe we should check whether `env` exists in this place.

marijnh commented 2022-05-04 10:52:43 +02:00 (Migrated from github.com)

Copy link

With this patch it'll still crash if process is not defined at all. I've pushed an alternative patch that should handle that too.

With this patch it'll still crash if `process` is not defined at all. I've pushed an alternative patch that should handle that too.

yunyuyuan commented 2022-05-04 12:24:28 +02:00 (Migrated from github.com)

Copy link

With this patch it'll still crash if process is not defined at all. I've pushed an alternative patch that should handle that too.

Thinks! I made a mistake with typescript.

> With this patch it'll still crash if `process` is not defined at all. I've pushed an alternative patch that should handle that too. Thinks! I made a mistake with typescript.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lezer/lr!61

No description provided.