lezer/sass
1
0
Fork 0
Code Issues Pull requests Activity

Support suffix #1

Closed
Tarrowren wants to merge 1 commit from main into main
pull from: main
merge into: lezer:main
Conversation 6 Commits 1 Files changed 2 +14
Tarrowren commented 2023-07-04 11:57:12 +02:00 (Migrated from github.com)
Copy link

https://github.com/Tarrowren/css-class-intellisense/issues/15

https://github.com/Tarrowren/css-class-intellisense/issues/15
marijnh commented 2023-07-04 13:13:30 +02:00 (Migrated from github.com)
Copy link

What feature does this implement (the linked issue explains absolutely nothing)?

What feature does this implement (the linked issue explains absolutely nothing)?
Tarrowren commented 2023-07-04 14:17:06 +02:00 (Migrated from github.com)
Copy link

I added the suffix feature.

https://sass-lang.com/documentation/style-rules/parent-selector/

image

I added the suffix feature. https://sass-lang.com/documentation/style-rules/parent-selector/ ![image](https://github.com/lezer-parser/sass/assets/35626141/b98965e4-4244-43ee-b041-314a080592a0)
marijnh commented 2023-07-05 14:45:40 +02:00 (Migrated from github.com)
Copy link

Why did you include selector? in the rule? It seems to work just as well without that.

Why did you include `selector?` in the rule? It seems to work just as well without that.
Tarrowren commented 2023-07-05 15:20:55 +02:00 (Migrated from github.com)
Copy link

suffix is used for className, which I think is close to classSelector.

suffix is not currently parsed correctly.
image

suffix is used for className, which I think is close to classSelector. suffix is not currently parsed correctly. ![image](https://github.com/lezer-parser/sass/assets/35626141/1af43c6e-8edd-49d7-ad47-be8a683ee744)
marijnh commented 2023-07-05 16:16:11 +02:00 (Migrated from github.com)
Copy link

That doesn't answer my question about the use of selector? in the new rule at all. Attached patch implements this in a way that seems more correct to me.

That doesn't answer my question about the use of `selector?` in the new rule at all. Attached patch implements this in a way that seems more correct to me.
Tarrowren commented 2023-07-07 05:41:44 +02:00 (Migrated from github.com)
Copy link

Sorry, I misunderstood what you said. It's not appropriate to use selector? here.

Sorry, I misunderstood what you said. It's not appropriate to use `selector?` here.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/sass!1
No description provided.