lezer/website
1
0
Fork 0
Code Issues Pull requests Activity

Update site.css #1

Closed
jdbruxelles wants to merge 1 commit from patch-1 into master
pull from: patch-1
merge into: lezer:master
Conversation 6 Commits 1 Files changed 1 +3 -3
jdbruxelles commented 2019-07-10 11:22:45 +02:00 (Migrated from github.com)
Copy link

Hi there, I think that 10px of padding is better for small screen.

Hi there, I think that 10px of padding is better for small screen.
jdbruxelles commented 2020-09-12 02:30:28 +02:00 (Migrated from github.com)
Copy link

Hi @marijnh,
It looks like you haven't taken a look at this pull request. Do I have to close it? Have a nice weekend.

Hi @marijnh, It looks like you haven't taken a look at this pull request. Do I have to close it? Have a nice weekend.
marijnh commented 2020-09-12 13:04:27 +02:00 (Migrated from github.com)
Copy link

Oh, sorry. I wasn't watching this repository for some reason (I think for a while github defaulted to not watching new repositories in orgs), so I didn't notice this until you mentioned me.

Oh, sorry. I wasn't watching this repository for some reason (I think for a while github defaulted to not watching new repositories in orgs), so I didn't notice this until you mentioned me.
marijnh commented 2020-09-12 13:06:23 +02:00 (Migrated from github.com)
Copy link

I think we'll have to override this back to 3px for the narrow-screen media selector, to avoid wasting too much space on phone screens.

I think we'll have to override this back to 3px for the narrow-screen media selector, to avoid wasting too much space on phone screens.
jdbruxelles commented 2020-09-12 15:31:25 +02:00 (Migrated from github.com)
Copy link

No problem. Ok, I totally understand this point of view. I think it would be better for curved screens to have a little extra margin to facilitate readability.

No problem. Ok, I totally understand this point of view. I think it would be better for curved screens to have a little extra margin to facilitate readability.
marijnh commented 2020-09-13 11:52:13 +02:00 (Migrated from github.com)
Copy link

Ugh, indeed, curved screens seem to push the margins into the curve. Not sure who thought that was a good idea.

But 10px remains too much of a margin on a phone screen. How about just using 5px everywhere?

Ugh, indeed, curved screens seem to push the margins into the curve. Not sure who thought that was a good idea. But 10px remains too much of a margin on a phone screen. How about just using 5px everywhere?
marijnh commented 2020-09-14 07:43:11 +02:00 (Migrated from github.com)
Copy link

Superseded by #7

Superseded by #7

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/website!1
No description provided.