marijn/heckle
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Make markdown renderer injectable #10

Merged
adrianheine merged 3 commits from injectMarkdown into master 2017-03-15 11:16:15 +01:00
Conversation 3 Commits 3 Files changed 4 +40 -24
adrianheine commented 2017-03-15 10:17:31 +01:00 (Migrated from github.com)
Copy link

This introduces a config option markdownRenderer which specifies a module used for markdown rendering.

This introduces a config option `markdownRenderer` which specifies a module used for markdown rendering.
marijnh (Migrated from github.com) reviewed 2017-03-15 10:24:27 +01:00
heckle.js
marijnh (Migrated from github.com) commented 2017-03-15 10:24:27 +01:00
Copy link

Maybe push the code highlighting down into the rendering module as well, and provide the default renderer as a separate file?

Marked is awful, by the way, maybe markdown-it (which didn't exist when when I wrote this) is a better default.

Maybe push the code highlighting down into the rendering module as well, and provide the default renderer as a separate file? Marked is awful, by the way, maybe markdown-it (which didn't exist when when I wrote this) is a better default.
adrianheine (Migrated from github.com) reviewed 2017-03-15 10:25:38 +01:00
heckle.js
adrianheine (Migrated from github.com) commented 2017-03-15 10:25:38 +01:00
Copy link

Sure (both), I just wanted to be minimally invasive. I switched to markdown-it locally.

Sure (both), I just wanted to be minimally invasive. I switched to `markdown-it` locally.
adrianheine commented 2017-03-15 11:08:48 +01:00 (Migrated from github.com)
Copy link

I switched to markdown-it and the diff for your blog looked good to me.

I switched to `markdown-it` and the diff for your blog looked good to me.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
marijn/heckle!10
No description provided.