marijn/heckle
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Make a post's file name configurable #9

Closed
adrianheine wants to merge 1 commit from postFileName into master
pull from: postFileName
merge into: marijn:master
Conversation 6 Commits 1 Files changed 1 +9 -5
adrianheine commented 2017-03-15 09:56:36 +01:00 (Migrated from github.com)
Copy link

Having different postLink and postFileName values obviously requires some server-side configuration.

Having different `postLink` and `postFileName` values obviously requires some server-side configuration.
marijnh commented 2017-03-15 10:14:28 +01:00 (Migrated from github.com)
Copy link

What's the use case for this? Prettifying urls and having your web server somehow redirect from those to concrete files with different names?

What's the use case for this? Prettifying urls and having your web server somehow redirect from those to concrete files with different names?
adrianheine commented 2017-03-15 10:15:11 +01:00 (Migrated from github.com)
Copy link

Yeah, exactly. I'd like to not have the file extension in URLs, but in file names.

Yeah, exactly. I'd like to not have the file extension in URLs, but in file names.
marijnh commented 2017-03-15 10:19:02 +01:00 (Migrated from github.com)
Copy link

Do I see correctly that this is a breaking change in behavior when you override the url for a post without also overriding the file name? It'll still store the file at ${name}.html, and probably break. Would it make more sense to not default postFileName to anything, and fall back to postLink when it's null?

Do I see correctly that this is a breaking change in behavior when you override the url for a post without also overriding the file name? It'll still store the file at `${name}.html`, and probably break. Would it make more sense to not default `postFileName` to anything, and fall back to `postLink` when it's null?
adrianheine commented 2017-03-15 10:20:54 +01:00 (Migrated from github.com)
Copy link

You're right, I didn't think of that. ${url} would also work as a default, right?

You're right, I didn't think of that. `${url}` would also work as a default, right?
marijnh commented 2017-03-15 10:24:59 +01:00 (Migrated from github.com)
Copy link

I think so. That's a decent solution.

I think so. That's a decent solution.
marijnh commented 2017-03-15 11:16:25 +01:00 (Migrated from github.com)
Copy link

Merged as e970886

Merged as e970886

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
marijn/heckle!9
No description provided.