Validate template is string when baking #2

Merged

brechtcs merged 1 commit from master into master 2020-10-25 13:45:37 +01:00

Conversation 0 Commits 1 Files changed 2 +12

brechtcs commented 2020-10-25 09:24:16 +01:00 (Migrated from github.com)

Copy link

If you directly pass an undecoded Buffer into bake, it throws an error only on dispatch, making it very hard to trace the original bug. This has tripped me up several times already (with some months in between). Added some validation to protect future me against this same mistake.

I don't think this is a breaking change, as it should only throw in code that's already broken.

If you directly pass an undecoded Buffer into `bake`, it throws an error only on `dispatch`, making it very hard to trace the original bug. This has tripped me up several times already (with some months in between). Added some validation to protect future me against this same mistake. I don't think this is a breaking change, as it should only throw in code that's already broken.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

marijn/mold!2

No description provided.