marijn/orderedmap
1
0
Fork 0
Code Issues 1 Pull requests Releases Activity

Use named export for ES module compatibility. #4

Closed
bradleyayers wants to merge 1 commit from master into master
pull from: master
merge into: marijn:master
Conversation 5 Commits 1 Files changed 1 +1 -1
bradleyayers commented 2017-05-30 05:13:53 +02:00 (Migrated from github.com)
Copy link

I'd expect a major bump after this is released.

I'd expect a major bump after this is released.
stephankaag commented 2018-09-04 11:43:20 +02:00 (Migrated from github.com)
Copy link

@marijnh What do you think? I need this as well.

@marijnh What do you think? I need this as well.
marijnh commented 2018-09-04 11:46:44 +02:00 (Migrated from github.com)
Copy link

Argh, sorry about never responding here.

In which context can you treat a CommonJS module as an ES module, but you can't use module.exports as export default?

Argh, sorry about never responding here. In which context can you treat a CommonJS module as an ES module, but you can't use `module.exports` as `export default`?
stephankaag commented 2018-09-04 12:34:59 +02:00 (Migrated from github.com)
Copy link

Now it's my turn to Argh ;-)

I had a wrong import statement somewhere else and i (incorrectly) blamed orderedmap. You can ignore my previous comment.

Now it's my turn to Argh ;-) I had a wrong import statement somewhere else and i (incorrectly) blamed orderedmap. You can ignore my previous comment.
marijnh commented 2018-09-04 12:36:28 +02:00 (Migrated from github.com)
Copy link

Okay, thanks. @bradleyayers Is this still something that would help you? If not, I'll close it.

Okay, thanks. @bradleyayers Is this still something that would help you? If not, I'll close it.
bradleyayers commented 2018-09-04 12:58:01 +02:00 (Migrated from github.com)
Copy link

I don't believe I need this since TypeScript added esModuleInterop.

I don't believe I need this since TypeScript added `esModuleInterop`.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
marijn/orderedmap!4
No description provided.