marijn/orderedmap
1
0
Fork 0
Code Issues 1 Pull requests Releases Activity

Add ESM support #5

Merged
laurentpellegrino merged 1 commit from pm-esm into master 2019-11-07 16:53:57 +01:00
Conversation 3 Commits 1 Files changed 4 +33 -2
laurentpellegrino commented 2019-11-07 12:29:35 +01:00 (Migrated from github.com)
Copy link

Here is the first PR we discussed.

The idea is to not touch the existing code but to generate the ESM version using rollup. The generated ESM version is included in the NPM package before releasing it. The module field is added to package.json for automatic detection by common tools.

Here is the first PR we discussed. The idea is to not touch the existing code but to generate the ESM version using rollup. The generated ESM version is included in the NPM package before releasing it. The `module` field is added to _package.json_ for automatic detection by common tools.
laurentpellegrino commented 2019-11-07 12:30:18 +01:00 (Migrated from github.com)
Copy link

@marijnh Please let me know what you think.

@marijnh Please let me know what you think.
marijnh commented 2019-11-07 16:54:39 +01:00 (Migrated from github.com)
Copy link

Thanks, works for me (though I'd have gone from an ES6 source file to a cjs output file). Published as 1.1.0.

Thanks, works for me (though I'd have gone from an ES6 source file to a cjs output file). Published as 1.1.0.
laurentpellegrino commented 2019-11-07 21:47:40 +01:00 (Migrated from github.com)
Copy link

Great, thanks (even if the code base is small, I use to write code in TypeScript and Java, so generating the ESM version was less error-prone and saved some time).

Great, thanks (even if the code base is small, I use to write code in TypeScript and Java, so generating the ESM version was less error-prone and saved some time).
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
marijn/orderedmap!5
No description provided.