marijn/style-mod
1
0
Fork 0
Code Issues Pull requests Releases Activity

Simplify type declarations #3

Closed
adrianheine wants to merge 1 commit from patch-2 into master
pull from: patch-2
merge into: marijn:master
Conversation 2 Commits 1 Files changed 1 +1 -1
adrianheine commented 2019-01-16 20:23:57 +01:00 (Migrated from github.com)
Copy link
No description provided.
marijnh commented 2019-01-16 21:07:48 +01:00 (Migrated from github.com)
Copy link

You did the exact reverse of github.com/marijnh/style-mod@2c7c093ab7 ;)

In short, I had it that way initially, but it created huge complicated types that looked terrible in error messages and when I hover over them in emacs, so I added this extra step.

You did the exact reverse of https://github.com/marijnh/style-mod/commit/2c7c093ab782f3a1712c9d35540f3f34627317ae ;) In short, I had it that way initially, but it created huge complicated types that looked terrible in error messages and when I hover over them in emacs, so I added this extra step.
adrianheine commented 2019-01-16 21:22:45 +01:00 (Migrated from github.com)
Copy link

Haha, that's funny. I actually thought about this consequence (huge types), but didn't think about editor integration.

Haha, that's funny. I actually thought about this consequence (huge types), but didn't think about editor integration.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
marijn/style-mod!3
No description provided.