prosemirror/prosemirror-changeset
1
0
Fork 0
Code Issues 1 Pull requests Activity

clarifies the position-mapping helper's scope #2

Closed
saranrapjs wants to merge 1 commit from clarifying-scope into master
pull from: clarifying-scope
merge into: prosemirror:master
Conversation 1 Commits 1 Files changed 1 +24 -24
saranrapjs commented 2017-10-18 17:58:24 +02:00 (Migrated from github.com)
Copy link

After spending some time this morning wrapping my head around these tests, I realized my eyes were getting confused by the anonymous functions' p not being the same as the prosemirror-test-helper's p! This is a nice-to-have patch that makes it a little easier to understand what's going on in these tests.

After spending some time this morning wrapping my head around these tests, I realized my eyes were getting confused by the anonymous functions' `p` not being the same as the `prosemirror-test-helper`'s `p`! This is a nice-to-have patch that makes it a little easier to understand what's going on in these tests.
marijnh commented 2017-10-18 18:04:09 +02:00 (Migrated from github.com)
Copy link

Good idea. Merged as 4c8fd79

Good idea. Merged as 4c8fd79

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-changeset!2
No description provided.