prosemirror/prosemirror-changeset
1
0
Fork 0
Code Issues 1 Pull requests Activity

Add a static fromChanges method to ChangeSet class #24

Closed
maitysubhasis wants to merge 1 commit from add-static-method-to-change-set into master
pull from: add-static-method-to-change-set
merge into: prosemirror:master
Conversation 9 Commits 1 Files changed 1 +14
maitysubhasis commented 2026-02-10 17:28:17 +01:00 (Migrated from github.com)
Copy link

If we want to create a ChangeSet from a deserialized Change list we need to have a way to pass the changes to the constructor.

Currently the constructor is marked @internal So adding this method.

If we want to create a ChangeSet from a deserialized Change list we need to have a way to pass the changes to the constructor. Currently the constructor is marked @internal So adding this method.
marijnh commented 2026-02-10 20:28:51 +01:00 (Migrated from github.com)
Copy link

What's wrong with calling ChangeSet.create(...).addSteps(...)?

What's wrong with calling `ChangeSet.create(...).addSteps(...)`?
maitysubhasis commented 2026-02-11 17:40:27 +01:00 (Migrated from github.com)
Copy link

For a large document there can be too many steps. To avoid fetching all those steps we decided to save the Change[] in db. This way we can load the the list and create ChangeSet and apply the recent Step[] on top.

For a large document there can be too many steps. To avoid fetching all those steps we decided to save the `Change[]` in db. This way we can load the the list and create `ChangeSet` and apply the recent `Step[]` on top.
marijnh commented 2026-02-12 11:27:05 +01:00 (Migrated from github.com)
Copy link

Ah, I see, you're asking for a direct serialization format. But it appears Span and Change also don't export their constructors. Could you take a look at attached patch and let me know whether it'd solve your problem?

Ah, I see, you're asking for a direct serialization format. But it appears `Span` and `Change` also don't export their constructors. Could you take a look at attached patch and let me know whether it'd solve your problem?
👍 1
sch commented 2026-02-12 15:21:19 +01:00 (Migrated from github.com)
Copy link

I like the symmetry in your patch with serializing Nodes and Steps. This would serve our use case nicely and avoid needing to extend the types with declaration merging in our app.

I like the symmetry in your patch with serializing Nodes and Steps. This would serve our use case nicely and avoid needing to extend the types with declaration merging in our app.
maitysubhasis commented 2026-02-12 15:31:11 +01:00 (Migrated from github.com)
Copy link

I made a comment for the patch. In summary the question is: how should we pass the optional parameters?

I made a comment for the [patch](https://github.com/ProseMirror/prosemirror-changeset/commit/fabfe3b23e96284d62742958191fdb4164ab9780#r177036658). In summary the question is: how should we pass the optional parameters?
marijnh commented 2026-02-12 15:32:04 +01:00 (Migrated from github.com)
Copy link

Pass undefined if you don't want to pass a non-default value.

Pass `undefined` if you don't want to pass a non-default value.
maitysubhasis commented 2026-02-12 17:14:47 +01:00 (Migrated from github.com)
Copy link

Thanks you. That would do!

Thanks you. That would do!
sch commented 2026-02-13 17:26:24 +01:00 (Migrated from github.com)
Copy link

I can confirm these changes work well with a vendored copy of this patch in our codebase.

I can confirm these changes work well with a vendored copy of [this patch](https://github.com/ProseMirror/prosemirror-changeset/commit/fabfe3b23e96284d62742958191fdb4164ab9780) in our codebase.
marijnh commented 2026-02-14 11:56:22 +01:00 (Migrated from github.com)
Copy link

I've published a version 2.4.0

I've published a version 2.4.0

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-changeset!24
No description provided.