prosemirror/prosemirror-changeset
1
0
Fork 1
Code Issues 1 Pull requests Activity

Fix isLetter ASCII range typo for a-z character range #25

Merged
marijn merged 1 commit from BartKrol/prosemirror-changeset:fix-isletter-ascii-range into main 2026-04-13 15:19:21 +02:00
Conversation 3 Commits 1 Files changed 2 +4 -1
BartKrol commented 2026-04-13 14:51:27 +02:00
Contributor
Copy link

Fixes a typo for ASCII range inside isLetter from 79 to 97.

CleanShot 2026-04-13 at 14.46.44

Fixes a typo for ASCII range inside `isLetter` from `79` to `97`. ![CleanShot 2026-04-13 at 14.46.44](/attachments/771709d4-ad5c-4b3b-bb90-9ce084dfdc4c)
CleanShot 2026-04-13 at 14.46.44.png
36 KiB 
The third clause checked charcodes 79-122 instead of 97-122, so '[', '\', ']', '^', '_', and '`' were incorrectly classified as letters
marijn merged commit d4542f745d into main 2026-04-13 15:19:21 +02:00
marijn commented 2026-04-13 15:20:14 +02:00
Owner
Copy link

Thanks for spotting that!

Thanks for spotting that!
BartKrol commented 2026-04-13 16:11:47 +02:00
Author
Contributor
Copy link

Thanks for merging this so quickly @marijn!

Quick question - do you have an estimate for the next release? I don’t want to rush things, but we would use the fix in our codebase. If it’s going to take a while, I’ll implement a workaround on our side in the meantime, so no problem!

Thanks for merging this so quickly @marijn! Quick question - do you have an estimate for the next release? I don’t want to rush things, but we would use the fix in our codebase. If it’s going to take a while, I’ll implement a workaround on our side in the meantime, so no problem!
marijn commented 2026-04-14 09:03:00 +02:00
Owner
Copy link

I've tagged prosemirror-changeset 2.4.1

I've tagged prosemirror-changeset 2.4.1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-changeset!25
No description provided.