prosemirror/prosemirror-commands
1
0
Fork 0
Code Pull requests Activity

Bind Ctrl-a and Ctrl-e on macOS #13

Merged
ocavue merged 2 commits from ocavue/mac_key_ctrl_a_e into master 2022-01-17 12:44:51 +01:00
Conversation 2 Commits 2 Files changed 2 +56 -1
ocavue commented 2022-01-17 12:19:59 +01:00 (Migrated from github.com)
Copy link

FIX: Add a workaround for a bug on macOS where Ctrl-a and
Ctrl-e getting stuck at the edge of inline nodes.

Issue https://discuss.prosemirror.net/t/shortcut-ctrl-a-ctrl-e-dont-work-on-macos-with-inline-node

  • I didn't bind these two commands to Home and End in pcBaseKeymap because the browsers on Windows don't seem to have this bug.
    (Test environment: Windows Server 2019 version 1809, Chrome 97, Firefox 96)
  • I'm not sure if these commands should be exported as public APIs, so I only exported them for testing.
FIX: Add a workaround for a bug on macOS where Ctrl-a and Ctrl-e getting stuck at the edge of inline nodes. Issue https://discuss.prosemirror.net/t/shortcut-ctrl-a-ctrl-e-dont-work-on-macos-with-inline-node --- - I didn't bind these two commands to `Home` and `End` in `pcBaseKeymap` because the browsers on Windows don't seem to have this bug. (Test environment: Windows Server 2019 version 1809, Chrome 97, Firefox 96) - I'm not sure if these commands should be exported as public APIs, so I only exported them for testing.
marijnh commented 2022-01-17 12:45:41 +01:00 (Migrated from github.com)
Copy link

Merged this, with some changes to export the commands and make them do the right thing inside inline nodes.

Merged this, with some changes to export the commands and make them do the right thing inside inline nodes.
ocavue commented 2022-01-17 12:49:08 +01:00 (Migrated from github.com)
Copy link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-commands!13
No description provided.