prosemirror/prosemirror-commands
1
0
Fork 0
Code Pull requests Activity

Fix shortcuts when CapsLock is on #16

Closed
z-950 wants to merge 1 commit from patch-1 into master
pull from: patch-1
merge into: prosemirror:master
Conversation 2 Commits 1 Files changed 1 +8 -2
z-950 commented 2022-10-11 10:50:50 +02:00 (Migrated from github.com)
Copy link
No description provided.
marijnh commented 2022-10-11 15:33:27 +02:00 (Migrated from github.com)
Copy link

I do not think it reasonable to shortcuts with modifiers to work with shift or caps lock on. I tried several applications, and they all do either something else or nothing for shift-ctrl-a.

I do not think it reasonable to shortcuts with modifiers to work with shift or caps lock on. I tried several applications, and they all do either something else or nothing for shift-ctrl-a.
z-950 commented 2022-10-12 05:14:08 +02:00 (Migrated from github.com)
Copy link

I agree. I only want to fix CaspLock on but not shift.

Ctrl + a with CapsLock on or off effects different. With CapsLock on, selecting all is caused by browser, which will cause scrolling.

I think shift is different with CapsLock on. CapsLock on is a state. It shouldn't be considered a part of shortcut key.

So may handle CapsLock in prosemirror-keymap better.

I agree. I only want to fix CaspLock on but not shift. `Ctrl + a` with CapsLock on or off effects different. With CapsLock on, selecting all is caused by browser, which will cause scrolling. I think shift is different with CapsLock on. CapsLock on is a state. It shouldn't be considered a part of shortcut key. So may handle CapsLock in `prosemirror-keymap` better.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-commands!16
No description provided.