prosemirror/prosemirror-commands
1
0
Fork 0
Code Pull requests Activity

Bind Enter to splitBlockKeepMarks instead of splitBlock #3

Closed
kofifus wants to merge 1 commit from patch-1 into master
pull from: patch-1
merge into: prosemirror:master
Conversation 1 Commits 1 Files changed 1 +1 -1
kofifus commented 2017-03-01 11:23:06 +01:00 (Migrated from github.com)
Copy link

As it is by far the more common situation in wysiwyg editors that marks persist after pressing enter, it makes sense for this to be the default in ProseMirror. A keymap can be used to revert Enter to use splitBlock instead.

As it is by far the more common situation in wysiwyg editors that marks persist after pressing enter, it makes sense for this to be the default in ProseMirror. A keymap can be used to revert Enter to use splitBlock instead.
marijnh commented 2017-03-01 11:24:18 +01:00 (Migrated from github.com)
Copy link

I disagree, as I described in our earlier discussion. So nope, not going to happen. It's easy enough to rebind, since most real-world setups will be setting up their own custom keymap anyway.

I disagree, as I described in our earlier discussion. So nope, not going to happen. It's easy enough to rebind, since most real-world setups will be setting up their own custom keymap anyway.
👎 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-commands!3
No description provided.