prosemirror/prosemirror-dropcursor
1
0
Fork 0
Code Pull requests Activity

Differentiate block vs. inline insert via CSS #16

Closed
mylesj wants to merge 1 commit from feat/css-block-inline-differentiation into master
pull from: feat/css-block-inline-differentiation
merge into: prosemirror:master
Conversation 2 Commits 1 Files changed 1 +12 -2
mylesj commented 2023-02-06 20:20:06 +01:00 (Migrated from github.com)
Copy link

Hi, I wondered if you'd consider supporting some additional CSS styling.

Visually the drop cursor seems to have two modes: a horizontal (block) insert; and a vertical (inline) caret-like insert - I'd like to be able to differentiate and style them separately but currently the API allows only for a single CSS class. I'm proposing that if the class configuration is being utilised then some additional classes are appended allowing for higher specificity. Alternatively a data-* attribute would work.

Hi, I wondered if you'd consider supporting some additional CSS styling. Visually the drop cursor seems to have two modes: a horizontal (block) insert; and a vertical (inline) caret-like insert - I'd like to be able to differentiate and style them separately but currently the API allows only for a single CSS class. I'm proposing that if the `class` configuration is being utilised then some additional classes are appended allowing for higher specificity. Alternatively a `data-*` attribute would work.
marijnh commented 2023-02-07 07:42:17 +01:00 (Migrated from github.com)
Copy link

Does attached patch, which does something similar, work for you?

Does attached patch, which does something similar, work for you?
mylesj commented 2023-02-07 08:38:10 +01:00 (Migrated from github.com)
Copy link

Yes, that's great. Thank you.

Yes, that's great. Thank you.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-dropcursor!16
No description provided.